Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync with upstream Crossplane-runtime changes #59

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Sync with upstream Crossplane-runtime changes #59

merged 9 commits into from
Oct 24, 2023

Conversation

stevendborrelli
Copy link
Collaborator

@stevendborrelli stevendborrelli commented Oct 22, 2023 •
edited
Loading

Description of your changes

Fixes #58

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

@stevendborrelli stevendborrelli changed the title update GetInteger to handle floats locally Sync with upstream Crossplane-runtime changes Oct 23, 2023
@stevendborrelli stevendborrelli changed the title Sync with upstream Crossplane-runtime changes WIP: Sync with upstream Crossplane-runtime changes Oct 23, 2023
@stevendborrelli
update test
85bbbfe 
Signed-off-by: Steven Borrelli <[email protected]>
@stevendborrelli
fix gci lint errors
168fe30 
Signed-off-by: Steven Borrelli <[email protected]>
@stevendborrelli
update generated pb
314d80d 
Signed-off-by: Steven Borrelli <[email protected]>
@stevendborrelli stevendborrelli mentioned this pull request Oct 23, 2023
Closed
@negz negz mentioned this pull request Oct 23, 2023
Closed
@negz
Copy link
Member

negz commented Oct 24, 2023

@stevendborrelli Can you fix the linter errors and I'll merge.

@stevendborrelli
gci updates
6731ae5 
Signed-off-by: Steven Borrelli <[email protected]>
@stevendborrelli
linter fixes
b93313e 
Signed-off-by: Steven Borrelli <[email protected]>
@stevendborrelli
more lint fixes
b69d72b 
Signed-off-by: Steven Borrelli <[email protected]>
@stevendborrelli stevendborrelli changed the title WIP: Sync with upstream Crossplane-runtime changes Sync with upstream Crossplane-runtime changes Oct 24, 2023
negz
negz approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevendborrelli!

@negz negz merged commit 66fe852 into crossplane:main Oct 24, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negz negz negz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of deprecated GetNumber() method from Crossplane Runtime
2 participants
@stevendborrelli @negz